Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, parser, executor, ddl worker: admin pause and resume ddl jobs #43674

Merged
merged 6 commits into from
May 11, 2023
Merged

ddl, parser, executor, ddl worker: admin pause and resume ddl jobs #43674

merged 6 commits into from
May 11, 2023

Conversation

dhysum
Copy link
Contributor

@dhysum dhysum commented May 10, 2023 •
edited
Loading

What problem does this PR solve?
Issue Number: close #18015 #40041

Related issue number: #39751 #43061

Problem Summary:

  • admin pause ddl jobs 3,5;
  • admin resume ddl jobs 3,5;

pause an running DDL; and resume the paused DDL.

What is changed and how it works?

Once received the admin pause request, it will mark the Job as pausing, then the background worker will turn the DDL job to be paused and mark it as not processing. While, the admin resume is the contrary way.

cherry-pick from :

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

- Support `admin pause ddl jobs 3,5;`
- Support `admin resume ddl jobs 3,5;`

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Benjamin2037
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels May 10, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 10, 2023
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2023

Hi @dhysum. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels May 10, 2023
@dhysum dhysum force-pushed the dev/release-7.1/ddl_pause_resume branch from e3b9c4f to ffe84e5 Compare May 10, 2023 07:05
@dhysum dhysum changed the title ddl, parser, executor : admin pause/resume ddl jobs ddl, parser, executor, ddl worker and reorg worker : admin pause/resume ddl jobs May 10, 2023
@dhysum dhysum changed the title ddl, parser, executor, ddl worker and reorg worker : admin pause/resume ddl jobs ddl, parser, executor, ddl worker: admin pause and resume ddl jobs May 10, 2023
@dhysum
Copy link
Contributor Author

dhysum commented May 10, 2023

/retest-required

@dhysum dhysum force-pushed the dev/release-7.1/ddl_pause_resume branch from 4c44fa3 to ac78fc1 Compare May 10, 2023 11:48
@dhysum
Copy link
Contributor Author

dhysum commented May 11, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2023
Benjamin2037
Benjamin2037 approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 11, 2023
@Benjamin2037
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 69a13e24b4e5d3addf30d5b5a77f00e6b104d4b1

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2023
@Benjamin2037
Copy link
Collaborator

/retest

@zimulala zimulala mentioned this pull request May 11, 2023
Merged
12 tasks
@dhysum dhysum force-pushed the dev/release-7.1/ddl_pause_resume branch from 69a13e2 to f606c0b Compare May 11, 2023 02:43
@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2023
@zimulala
Copy link
Contributor

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2023

This pull request has been accepted and is ready to merge.

Commit hash: f606c0b

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 11, 2023
@dhysum
Copy link
Contributor Author

dhysum commented May 11, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 18783b9 into pingcap:release-7.1 May 11, 2023
This was referenced May 11, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dhysum @hawkingrei @Benjamin2037 @zimulala @VelocityLight